Starling update to version 2.7?

#1

Is there any chance to update Starling OpenFL to version 2.7?

Original changelog:

Thx!

2 Likes
#2

The best way would be to use a tool like WinMerge or Meld and compare Starling 2.6 and 2.7 to find the differences, then look to apply them to the Haxe version. It could be done commit-by-commit, though trying to do it wholesale in one commit (with the help of a diff tool) is probably the most productive route

1 Like
#3

Hello,

If nobody is working on this Iā€™ll probably have a look at it, not sure when though :sweat_smile:

1 Like
#4

Good news) Thx!
Starling 2.6 brings very useful ButtonBehavior class.

P.S. I think it will be very useful for OpenFL too.

#5

It will be usefulā€¦ for people using Starling in OpenFL :slight_smile:

I have no idea how many people do that, but I use Starling and still plan to use it for a while (I mostly use Feathers for UI though) plus this will be a good thing for potential as3 users that would like to switch to OpenFL

Iā€™ll follow singmajestyā€™s advice and have a look with winmerge to get an idea of how much work is involved

2 Likes
#6

I think Starling need own version of new OpenFL ChildAccess class
It is not difficult to create an analogue for Starling.

And there is pull request with fixing Std.is deprecation warnings.

Seems it can be nice update for Starling after 4 years)

1 Like
#7

Thanks, if you have more links like this pull request please share !

I donā€™t know about adding features that are not part of the original Starlingā€¦ Iā€™m all for it but my knowledge of the open source culture is not that great : is it ok to do so ?

#8

The philosophy of open source encourages forking and making changes to fit your needs. This sort of thing is definitely not frowned upon.

2 Likes
#9

Thatā€™s good to know, thanks Josh.

I guess itā€™s fine as long as the changes donā€™t ā€œbreakā€ anything and are pretty much optionnal or invisible enhancements.

Of course on my own fork I feel free to do whatever I want, but here it would be an update to the ā€œofficialā€ openFL Starling, hence my question :slight_smile:

#10

Since ChildAccess is an enhancement specifically for Haxe that shouldnā€™t conflict with anything from the original Starling, I think that itā€™s fine.

#11

I believe Iā€™m done with the initial 2.7 update, for anyone interested itā€™s here GitHub - MatseFR/starling at v2.7

Iā€™m gonna have a look at the differences between the 2.7 release and the current code on as3 starling, I think there have been additionnal commits.

Then Iā€™ll look into the ChildAccess thing

3 Likes
#12

I fixed a few issues on 2.7 branch (DisplacementMapFilter looking weird, Color.interpolate returning weird values)
Iā€™m also done with the changes from 2.7 to the current as3 Starling Github, I created another branch : GitHub - MatseFR/starling at current-as3-starling

warning : I didnā€™t do the changes on AssetManager for mimeType detection (lazy + not comfortable tackling those as Iā€™m unfamiliar with Haxe XML)

1 Like
#13

You can use this as a start point - ChildAccess.hx ā€” ŠÆŠ½Š“ŠµŠŗс.Š”ŠøсŠŗ

#14

ChildAccess class for Starling here starling/ChildAccess.hx at current-as3-starling Ā· MatseFR/starling Ā· GitHub

I grouped properties and methods for each class or my head would explode :sweat_smile:

I put it in starling.extensions so itā€™s clear itā€™s not part of the original lib

There was a small update to TextField too, some stuff I missed in the previous updates.

1 Like
#15

Wow, cool! Using Starling extensively, will definitely give updated version a try. Thanks for updating it!

BTW: there was a problem that leads to crashes on MacOs. Problem is specific to Haxe code generation, not starling itself: MacOs monteray: app crashes - #2 by Ilja_Razinkov
seems it is the same in your updated version (needs to be fixed), i can make a pull request if needed

1 Like
#16

Thanks for the heads up ! I committed your fix (use an Array and use resize(0) instead of .length = 0)

Starling is great, it deserves a bit more exposure :slight_smile:

Iā€™m not sure what more needs to be done now : I updated the source code and the haxelib.json fileā€¦ whatā€™s next ?

1 Like
#17

Starling is great, it deserves a bit more exposure

Totally agree :slight_smile:

Iā€™m not sure what more needs to be done now : I updated the source code and the haxelib.json fileā€¦ whatā€™s next ?

Probably do haxelib register && submit ( Using Haxelib - Haxelib Documentation ) with the name like starling-hx (for example). Or get in touch with singmajesty / tbyrne / p.j.shand (contributors, mentioned here: https://lib.haxe.org/p/starling/ ) for making update to current starling haxelib.

Starling work great as is already, seems Air dev is also slowed down, so hopefully there will be no need for serious changes in future (anyway willing try to help since iā€™m using it and have no plans to switch).

#18

Open a pull request?

#19

Iā€™ve been doing this on my github but the idea was to end up with a pull request to the openFL github :slight_smile:

That being said, I think the situation on openFL starling has problems : for example the pull request that fixes the Std.is issue should have been merged long ago. It kinda feels like a ghost ship right now (no offense intended)

I donā€™t know how it works but I think we would need someone with an actual interest in Starling to have access to the levers on openFL-starlingā€™s github. At least being able to merge pull requests.

#20

Yeah, looks fine. Merged.

1 Like