Reverb with OpenAL in windows build

CawawaC · July 25, 2018, 9:41am

Hi OpenFLians!

I’m working with somewhat advanced audio features and currently having issues with OpenAL use in windows builds: reverb is not working. I mean it looks like it’s created, but I can’t hear it, it’s not there. I’m at a loss, since it’s working on neko builds.
Other effects seem to be working ok. Switching the standard reverb for the eax one makes the game crash a few milliseconds after reverb creation.

Do you have any tips on how to make this work?

singmajesty · July 26, 2018, 6:49pm

That’s strange, it works on Neko, but not on Windows C++?

What methods do you call in the OpenAL-Soft API to create the reverb? Perhaps we can inspect the bindings or other code to see if there’s something that HXCPP and Neko might treat differently

CawawaC · July 27, 2018, 7:27am

That’s strange, it works on Neko, but not on Windows C++?

Exactly.

What methods do you call in the OpenAL-Soft API to create the reverb?

Nothing extraordinary really in the creation part:

aux = AL.createAux();
var fx = AL.createEffect();
AL.effecti(fx, AL.EFFECT_TYPE, AL.EFFECT_REVERB);
AL.effectf(fx, AL.REVERB_DECAY_TIME, 5.0);
AL.effectf(fx, AL.REVERB_GAIN, 0.4);
AL.auxi(aux, AL.EFFECTSLOT_EFFECT, fx);

And then, to use it, it’s a matter of getting a NativeAudioSource backend from a SoundChannel and playing it through the aux.

var source = @:privateAccess soundChannel.__source;
var backend:lime._backend.native.NativeAudioSource = @:privateAccess source.backend;
AL.source3i(backend.handle, AL.AUXILIARY_SEND_FILTER, aux, sendIndex, AL.FILTER_NULL);

Can’t see why OpenAL would act differently in a windows build.

singmajesty · July 27, 2018, 4:59pm

It might be the AL.source3i call.

aux is not an Int, but a CFFIPointer. The parameter appears to be dynamic on the CFFI side in C++, but not here:

github.com

openfl/lime/blob/develop/src/lime/media/openal/AL.hx#L1278




	public static function source3f (source:ALSource, param:Int, value1:Float, value2:Float, value3:Float):Void {


		#if (lime_cffi && lime_openal && !macro)
		NativeCFFI.lime_al_source3f (source, param, value1, value2, value3);
		#end


	}




	public static function source3i (source:ALSource, param:Int, value1:Int, value2:Int, value3:Int):Void {


		#if (lime_cffi && lime_openal && !macro)
		NativeCFFI.lime_al_source3i (source, param, value1, value2, value3);
		#end


	}




	public static function sourcef (source:ALSource, param:Int, value:Float):Void {

Does it work differently if you change value1 to Dynamic instead of Int?

CawawaC · July 27, 2018, 6:38pm

All right! That worked! thanks @singmajesty, you had the perfect answer, as usual

I made a pull request for the master branch.