Android emulator inverted colors

pozirk · December 6, 2018, 7:20pm

Hello!
I’ve built my game for android x86 and tried it on emulator, cause I don’t have actual device.
I’ve got all the color inverted and don’t know, if it’s emulator thing(all other apps’ colors are fine) or something with my game.
Here is screenshot of emulator vs normal image.
Did anyone have similar problems?
Thanks!

singmajesty · December 6, 2018, 11:34pm

It’s only on the emulator.

We use BGRA premultiplied textures on native, and most all devices support the OpenGL extension for BGRA texture support – except the Android emulator. This hasn’t been a high priority, but I’d love to see a fix.

I think there’s a fix here for HTML5:

github.com

openfl/openfl/blob/5e0bb98d2588cf81ee91e69a3051145af1a6ddea/src/openfl/display/BitmapData.hx#L1613


			if (__surface != null) {
				
				__surface.flush ();
				
			}
			
			var textureImage = image;
			
			#if (js && html5)
			
			if (#if openfl_power_of_two true || #end (!TextureBase.__supportsBGRA && textureImage.format != RGBA32)) {
				
				textureImage = textureImage.clone ();
				textureImage.format = RGBA32;
				//textureImage.buffer.premultiplied = true;
				#if openfl_power_of_two
				textureImage.powerOfTwo = true;
				#end
				
			}

Perhaps that logic could be used on other platforms as well, to double check that __supportsBGRA is true before we allow a BGRA texture? (like adding it to this if statement below:

github.com

openfl/openfl/blob/5e0bb98d2588cf81ee91e69a3051145af1a6ddea/src/openfl/display/BitmapData.hx#L1626


				textureImage.format = RGBA32;
				//textureImage.buffer.premultiplied = true;
				#if openfl_power_of_two
				textureImage.powerOfTwo = true;
				#end
				
			}
			
			#else
			
			if (#if openfl_power_of_two !textureImage.powerOfTwo || #end (!textureImage.premultiplied && textureImage.transparent)) {
				
				textureImage = textureImage.clone ();
				textureImage.premultiplied = true;
				#if openfl_power_of_two
				textureImage.powerOfTwo = true;
				#end
				
			}
			
			#end

pozirk · December 6, 2018, 11:53pm

Ah good!
Thank you for explanation.

singmajesty · December 7, 2018, 12:06am

If you test out and have a fix on your end, please let me know and we can merge it in

pozirk · December 8, 2018, 5:22pm

OK, I’ll try…